Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proj4] Fix the usage #19474

Merged
merged 10 commits into from
Aug 13, 2021
Merged

[proj4] Fix the usage #19474

merged 10 commits into from
Aug 13, 2021

Conversation

PhoebeHui
Copy link
Contributor

@PhoebeHui PhoebeHui commented Aug 10, 2021 •
edited
Loading

Fixes #19298 (comment)

Fix the issue that the usage use ${} syntax, but '@only' was added to the configure line.

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Aug 10, 2021
@PhoebeHui PhoebeHui mentioned this pull request Aug 10, 2021
Merged
dg0yt
dg0yt reviewed Aug 11, 2021
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also an obsolete PREFER_NINJA option.

ports/proj4/usage Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Aug 11, 2021
@PhoebeHui
Copy link
Contributor Author

The baseline issue would be fixed by PR #19516.

@dan-shaw dan-shaw merged commit 612102b into microsoft:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY left review comments

@dg0yt dg0yt dg0yt left review comments

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PhoebeHui @BillyONeal @dg0yt @NancyLi1013 @JackBoosY @dan-shaw